Support explicit build constraints in install flows#68962
Draft
nailo2c wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2 of the four-PR replacement for #65511.
It lets image and in-container installation flows consume an explicitly configured build constraints URL or local non-empty file. When no build constraints location is configured, the existing installation commands remain unchanged and perform no build-constraints download or inference.
The explicit constraints use the correct installer flags (
uv --build-constraintsandpip --build-constraint). Constraint-retry fallbacks remove both runtime and build constraints, while sourceuv syncinstallation remains unchanged.This PR is intentionally opened as a draft while #68937 is unmerged. Its branch is based directly on
mainand does not contain PR 1 commits. The intended merge order is:After #68937 merges, this PR will be rebased onto the updated
main. Breeze-facing options and automatic selection of generated build constraints remain deferred to later PRs.Validation:
breeze run pytest scripts/tests/in_container/test_build_constraints_installation.py -xvs— 34 passedprek run update-inlined-dockerfile-scripts --all-filesprek run ruff --from-ref upstream/mainprek run ruff-format --from-ref upstream/mainprek run --from-ref upstream/main --stage pre-commitprek run --from-ref upstream/main --stage manualDockerfile.cirelated: #54394
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines